Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade tools #3730

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

hawkingrei
Copy link
Contributor

@hawkingrei hawkingrei commented Oct 18, 2023

What type of PR is this?

Uncomment one line below and remove others.

Bug fix
Feature
Documentation
Other

What does this PR do? Why is it needed?

x/tools is too old to upgrade the linter such as golangci-linter.

Which issues(s) does this PR fix?

Fixes #3640

Other notes for review

@hawkingrei
Copy link
Contributor Author

@sluongng I've decided to push this forward, it seems that it needs to have an upload to mirror?

@sluongng
Copy link
Contributor

@hawkingrei hawkingrei force-pushed the try_to_upgrade_tools branch 2 times, most recently from 4464e94 to dff3939 Compare October 28, 2023 17:14
@hawkingrei hawkingrei force-pushed the try_to_upgrade_tools branch from 3172c24 to 0f81c57 Compare October 30, 2023 03:39
@hawkingrei
Copy link
Contributor Author

@sluongng CI has passed.

@hawkingrei
Copy link
Contributor Author

@fmeum PTAL

Copy link
Contributor

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Curious readers might want to give https://github.com/golang/tools/releases a read for latest features. A lot of them are gopls related, which are irrelevant to rules_go, but the analysis and memory improvements are interesting regardless.

@fmeum
Copy link
Member

fmeum commented Oct 30, 2023

Thanks for taking this on! Looks good to me.

@tyler-french Could you give this a test run?

Copy link
Contributor

@tyler-french tyler-french left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! Looks good to me.

@tyler-french Could you give this a test run?

@fmeum working on testing this now.

@hawkingrei Could you git rebase -i and squash this PR into one commit? This might make it a bit easier to test.

Also added a couple of comments.

go/tools/builders/nogo_main.go Outdated Show resolved Hide resolved
go/tools/builders/nogo_main.go Outdated Show resolved Hide resolved
go/tools/builders/nogo_main.go Outdated Show resolved Hide resolved
@hawkingrei hawkingrei force-pushed the try_to_upgrade_tools branch 3 times, most recently from 21b88be to 1dcec52 Compare October 31, 2023 15:39
@hawkingrei
Copy link
Contributor Author

Thanks for taking this on! Looks good to me.
@tyler-french Could you give this a test run?

@fmeum working on testing this now.

@hawkingrei Could you git rebase -i and squash this PR into one commit? This might make it a bit easier to test.

Also added a couple of comments.

I have rebased it.

@hawkingrei hawkingrei force-pushed the try_to_upgrade_tools branch from 1dcec52 to a3ec8cf Compare October 31, 2023 15:45
upgrade x/tools v0.14.0
upgrade x/sys   v0.13.0

Signed-off-by: Weizhen Wang <[email protected]>
@fmeum fmeum force-pushed the try_to_upgrade_tools branch from a3ec8cf to d9ed41f Compare November 1, 2023 21:22
@fmeum fmeum enabled auto-merge (squash) November 1, 2023 21:22
@fmeum
Copy link
Member

fmeum commented Nov 1, 2023

@hawkingrei Thanks!

@fmeum fmeum merged commit df20c98 into bazel-contrib:master Nov 1, 2023
2 checks passed
@hawkingrei hawkingrei deleted the try_to_upgrade_tools branch November 2, 2023 05:07
@hawkingrei
Copy link
Contributor Author

@hawkingrei Thanks!

When will we release a new rules_go on the github release ?

@fmeum
Copy link
Member

fmeum commented Nov 3, 2023

@tyler-french is already working on it

renovate bot referenced this pull request in kreempuff/rules_unreal_engine Nov 20, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.42.0` -> `v0.43.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0)

#### Breaking `x/tools` upgrade

This change includes a breaking upgrade to
[golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools)

Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure
compatibility with rules_go's NoGo.

**If you need to use an older version of `x/tools` (`v0.13.0` or
earlier), apply the following patch to `rules_go`**:

[x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch)

#### What's Changed

- Test BCR test module on macos_arm64 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715)
- update documentation for `0.42.0` release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716)
- add netrc support to go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- Temporarily disable Bzlmod explicitly by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720)
- Fix urls used to get auth in go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724)
- Include `go.env` in `//go` runfiles by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722)
- Update arm platform constraint to latest value in bazel. by
[@&#8203;BryanDClark](https://togithub.com/BryanDClark) in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- Add toolchain param to affected actions by
[@&#8203;kotlaja](https://togithub.com/kotlaja) in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- upgrade tools by [@&#8203;hawkingrei](https://togithub.com/hawkingrei)
in
[https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730)
- Also take library deps like srcs into account in go context by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725)
- Add go_cross_binary to README by
[@&#8203;jfirebaugh](https://togithub.com/jfirebaugh) in
[https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744)
- Update `bazel_features` to v1.1.1 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747)
- builder: Make paths absolute for stdliblist
([#&#8203;1357](https://togithub.com/bazelbuild/rules_go/issues/1357))
by [@&#8203;zecke](https://togithub.com/zecke) in
[https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748)
- feat(gopackagesdriver): add base test case for go packages driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743)
- Fix bazel query scope not being used by
[@&#8203;rastenis](https://togithub.com/rastenis) in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- Add support for `xtest` packages in Go Packages Driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750)
- upgrade x/tools to 0.15.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751)
- bug fix: parse embeds in files that contain the double quote rune by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)
- prepare release 0.43.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745)

#### New Contributors

- [@&#8203;justinwon777](https://togithub.com/justinwon777) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- [@&#8203;BryanDClark](https://togithub.com/BryanDClark) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- [@&#8203;kotlaja](https://togithub.com/kotlaja) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- [@&#8203;rastenis](https://togithub.com/rastenis) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- [@&#8203;andyscott](https://togithub.com/andyscott) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)

**Full Changelog**:
bazel-contrib/rules_go@v0.42.0...v0.43.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/bazel-starlib Nov 20, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.42.0` -> `v0.43.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0)

#### Breaking `x/tools` upgrade

This change includes a breaking upgrade to
[golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools)

Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure
compatibility with rules_go's NoGo.

**If you need to use an older version of `x/tools` (`v0.13.0` or
earlier), apply the following patch to `rules_go`**:

[x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch)

#### What's Changed

- Test BCR test module on macos_arm64 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715)
- update documentation for `0.42.0` release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716)
- add netrc support to go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- Temporarily disable Bzlmod explicitly by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720)
- Fix urls used to get auth in go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724)
- Include `go.env` in `//go` runfiles by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722)
- Update arm platform constraint to latest value in bazel. by
[@&#8203;BryanDClark](https://togithub.com/BryanDClark) in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- Add toolchain param to affected actions by
[@&#8203;kotlaja](https://togithub.com/kotlaja) in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- upgrade tools by [@&#8203;hawkingrei](https://togithub.com/hawkingrei)
in
[https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730)
- Also take library deps like srcs into account in go context by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725)
- Add go_cross_binary to README by
[@&#8203;jfirebaugh](https://togithub.com/jfirebaugh) in
[https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744)
- Update `bazel_features` to v1.1.1 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747)
- builder: Make paths absolute for stdliblist
([#&#8203;1357](https://togithub.com/bazelbuild/rules_go/issues/1357))
by [@&#8203;zecke](https://togithub.com/zecke) in
[https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748)
- feat(gopackagesdriver): add base test case for go packages driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743)
- Fix bazel query scope not being used by
[@&#8203;rastenis](https://togithub.com/rastenis) in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- Add support for `xtest` packages in Go Packages Driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750)
- upgrade x/tools to 0.15.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751)
- bug fix: parse embeds in files that contain the double quote rune by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)
- prepare release 0.43.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745)

#### New Contributors

- [@&#8203;justinwon777](https://togithub.com/justinwon777) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- [@&#8203;BryanDClark](https://togithub.com/BryanDClark) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- [@&#8203;kotlaja](https://togithub.com/kotlaja) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- [@&#8203;rastenis](https://togithub.com/rastenis) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- [@&#8203;andyscott](https://togithub.com/andyscott) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)

**Full Changelog**:
bazel-contrib/rules_go@v0.42.0...v0.43.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Nov 22, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.42.0` -> `v0.43.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0)

#### Breaking `x/tools` upgrade

This change includes a breaking upgrade to
[golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools)

Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure
compatibility with rules_go's NoGo.

**If you need to use an older version of `x/tools` (`v0.13.0` or
earlier), apply the following patch to `rules_go`**:

[x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch)

#### What's Changed

- Test BCR test module on macos_arm64 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715)
- update documentation for `0.42.0` release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716)
- add netrc support to go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- Temporarily disable Bzlmod explicitly by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720)
- Fix urls used to get auth in go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724)
- Include `go.env` in `//go` runfiles by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722)
- Update arm platform constraint to latest value in bazel. by
[@&#8203;BryanDClark](https://togithub.com/BryanDClark) in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- Add toolchain param to affected actions by
[@&#8203;kotlaja](https://togithub.com/kotlaja) in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- upgrade tools by [@&#8203;hawkingrei](https://togithub.com/hawkingrei)
in
[https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730)
- Also take library deps like srcs into account in go context by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725)
- Add go_cross_binary to README by
[@&#8203;jfirebaugh](https://togithub.com/jfirebaugh) in
[https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744)
- Update `bazel_features` to v1.1.1 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747)
- builder: Make paths absolute for stdliblist
([#&#8203;1357](https://togithub.com/bazelbuild/rules_go/issues/1357))
by [@&#8203;zecke](https://togithub.com/zecke) in
[https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748)
- feat(gopackagesdriver): add base test case for go packages driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743)
- Fix bazel query scope not being used by
[@&#8203;rastenis](https://togithub.com/rastenis) in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- Add support for `xtest` packages in Go Packages Driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750)
- upgrade x/tools to 0.15.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751)
- bug fix: parse embeds in files that contain the double quote rune by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)
- prepare release 0.43.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745)

#### New Contributors

- [@&#8203;justinwon777](https://togithub.com/justinwon777) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- [@&#8203;BryanDClark](https://togithub.com/BryanDClark) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- [@&#8203;kotlaja](https://togithub.com/kotlaja) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- [@&#8203;rastenis](https://togithub.com/rastenis) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- [@&#8203;andyscott](https://togithub.com/andyscott) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)

**Full Changelog**:
bazel-contrib/rules_go@v0.42.0...v0.43.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nogo_main fail to build when to upgrade golang.org/x/tools
4 participants